8000 docs: update `.env` section by xuzuodong · Pull Request #22369 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

docs: update .env section #22369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 30, 2023
Merged

docs: update .env section #22369

merged 5 commits into from
Jul 30, 2023

Conversation

xuzuodong
Copy link
Contributor
@xuzuodong xuzuodong commented Jul 28, 2023 •
edited by danielroe
Loading

🔗 Linked issue

resolves #22331

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Also improved readability a little bit.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@xuzuodong
chore(docs): update .env section
3b02503 
Resolves #22331 , and improve readability.
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@nuxt-studio
Copy link
Contributor
nuxt-studio bot commented Jul 28, 2023 •
edited
Loading

✅ Live Preview ready!

Name Edit Preview Latest Commit
Nuxt Docs Edit on Studio ↗︎ View Live Preview c51c7a4

pi0
pi0 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member
@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Two things could be improved:

  • Title: Maybe something like Production Preview?
  • Dotenv: We need to specify this dependency needs to be installed as well

@danielroe
Copy link
Member

This is great - thank you! ❤️

I wouldn't recommend using node -r dotenv/config for production as it requires dependencies to be installed in the package directory. But .output/ is intended to be the only build output required. (And if you have dependencies installed you might as well run nuxi preview.)

@xuzuodong
Copy link
Contributor Author

I think nuxi preview should be the recommended way, now is it better?

danielroe
danielroe approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member
@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

Thank you.

@danielroe danielroe merged commit f6a350e into nuxt:main Jul 30, 2023
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot access environment variables in useRuntimeConfig using source .env && node server.mjs
3 participants
@xuzuodong @danielroe @pi0
0