8000 fix(nuxt): await `prerender:routes` hook by rudolfbyker · Pull Request #22247 · nuxt/nuxt · GitHub
[go: up one dir, main page]
Skip to content

fix(nuxt): await prerender:routes hook #22247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

fix(nuxt): await prerender:routes hook #22247

merged 1 commit into from
Jul 20, 2023

Conversation

rudolfbyker
Copy link
Contributor

🔗 Linked issue

#22245

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

This feels like a new feature, or an enhancement of an existing feature, but seeing how simple the fix was, and that the docs have examples of asynchronous hooks without stating whether some or all hooks support async, I marked this as a bug fix.

📚 Description

Resolves #22245

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(nuxt): Support async prerender:routes hooks. fix(nuxt): await prerender:routes hook Jul 20, 2023
@danielroe danielroe merged commit 9742bff into nuxt:main Jul 20, 2023
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
Merged
@rudolfbyker rudolfbyker deleted the issue-22245 branch July 20, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

@rudolfbyker rudolfbyker

Labels
3.x bug 🔨 p3-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support async function for the prerender:routes hook.
2 participants
@rudolfbyker @danielroe
0