Conversation
|
@f34rdotcom, any updates here? I'm hoping for a new release to be published with this and #56. I'd like to avoid having to fork this repo and upload to PyPI myself. It's been a while since you've acknowledged any of these issues/fixes. |
|
@endlesscoil, are you able to help out here? There are Home Assistant users who've paid for AlarmDecoder devices and are waiting for the fixes in #52 to be published to resolve some outstanding issues. |
|
@ajschmidt8 While Python 2.x is thankfully EOL'd, the alarmdecoder webapp has the ability to auto-update, and there's a high potential for legacy users to still be using 2.7. We need to ensure that any changes do not affect them. I'll merge it if you fix the 2.7 tests. |
If you can ensure that the rest of the tests on the dev branch succeed I can at least push it to master for you. I don't have an alarmdecoder nor the ability to make a new pypi release, so any contributions I can make will mostly be in the form of menial Git tasks. |
Got it. Appreciate the help. I will try to take a look at these Python 2.x test cases today or later this week. |
|
I would get calls when people update from the older webapp but long ago I added warnings about doing updates on the update pages. Now 99% of the people never update anything ever so I don't expect too many support issues. I am prepared if we break a few eggs if it allows this to move forward. Approx 1k webapp instances are online today. |
Awesome. I will hold off on the Python 2 tests then. Should I update the README to mention Python 3+ support? Or maybe add some kind of deprecation/unsupported notice for Python 2? |
|
Fixed the Python 2 tests. I have a call scheduled with Sean this weekend, so we can hold off on merging until then. |
|
merging into |
This PR updates the Python 3 unit tests for the changes that were introduced in both d809cb3 and #52.
There may be some Python 2 unit tests still failing, but that's been EOL for over a year now so I'm not sure it's worth fixing them.
Hoping this helps us move closer to a new AlarmDecoder release being published.
(cc @endlesscoil, @f34rdotcom).