This repository was archived by the owner on Jan 8, 2023. It is now read-only.
Issue 8 #9
Merged
Issue 8 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Although merged, I'm still looking for a code review. I'll continue on a new PR after having run a series of live tests using fake features, releases, hotfixes. @asbjornu In particular, I've done some stuff in program logic because that's how I know how to do it, but if GitVersion can do it simply by changing settings, that will be better since we want to port the same approach to other repos. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't close the issue. In order to test it, I'm putting it into master and then will do a series of simulated changes, exercising the different branch types. Then we'll do a final review before closing the issue.
The actual code in NUnit.System.Linq is not changing and we'll move to a final 1.0 release subsequently, so that these extra releases won't matter.