8000 Add asciidtype by ngoldbaum · Pull Request #10 · numpy/numpy-user-dtypes · GitHub
[go: up one dir, main page]
Skip to content

Add asciidtype #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 7, 2022
Merged

Add asciidtype #10

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a0152f
add missing error handling
ngoldbaum Dec 5, 2022
ed95d72
adding initial implementation of asciidtype; compiles but untested
ngoldbaum Dec 5, 2022
1de1a14
add compilation database for asciidtype to pre-commit hook
ngoldbaum Dec 5, 2022
a907087
ASCIIDType creation works
ngoldbaum Dec 6, 2022
fd500a6
add asciidtype tests to CI run
ngoldbaum Dec 6, 2022
c6f0262
add missing decref
ngoldbaum Dec 6, 2022
d34c656
array creation works
ngoldbaum Dec 6, 2022
808970f
fix github actions workflow
ngoldbaum Dec 6, 2022
6be8300
only have one loop for unaligned or strided casts
ngoldbaum Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add missing decref
  • Loading branch information
@ngoldbaum
ngoldbaum committed Dec 6, 2022
commit c6f026280e5f28d421c2f68a4dc3ad5394005ddc
1 change: 1 addition & 0 deletions asciidtype/asciidtype/src/dtype.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ get_value(PyObject *scalar)
PyObject *res_bytes = PyUnicode_AsASCIIString(value);
Py_DECREF(value);
char *res = PyBytes_AsString(res_bytes);
Py_DECREF(res_bytes);
if (res == NULL) {
return NULL;
}
Expand Down
0