10000 Use _DtypeLike instead of Optional[dtype] by unnonouno · Pull Request #81 · numpy/numpy-stubs · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Use _DtypeLike instead of Optional[dtype] #81

Merged
merged 1 commit into from
May 19, 2020
Merged

Use _DtypeLike instead of Optional[dtype] #81

merged 1 commit into from
May 19, 2020

Conversation

unnonouno
Copy link
Contributor

I think _DtypeLike is better than Optional[dtype]. Can you replace them?

person142
person142 reviewed May 17, 2020
View reviewed changes
Copy link
Member
@person142 person142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @unnonouno, changes look good, but in a recent change _DtypeLike has been made public, so you'll need to rebase and change those _DtypeLikes to DtypeLike.

@unnonouno
Copy link
Contributor Author

Ok, thank you. I replaced them.

@person142 person142 merged commit 66369f9 into numpy:master May 19, 2020
@person142
Copy link
Member

Thanks @unnonouno.

@unnonouno unnonouno deleted the use-dtype-like branch May 19, 2020 01:23
@unnonouno
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@person142 person142 person142 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unnonouno @person142
0