This repository was archived by the owner on Jun 10, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
ENH: Add type annotations for the np.core.fromnumeric module: part 1/4 #67
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dd7a601
Added ".DS_Store" to .gitgnore
36581cb
Added 11 functions from np.core.fromnumeric
c2eeada
Downgraded black from 19.10b0 to 18.9b0
37cbded
Added a module-level docstring with the name of the corresponding num…
36efcf3
Implemented feedback from https://github.com/numpy/numpy-stubs/pull/6…
837eec6
Replaced the nested unions with _ArrayLikeIntNested
11dd7e4
Ran black again
35e1cda
Implement the feedback from https://github.com/numpy/numpy-stubs/pull…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added a module-level docstring with the name of the corresponding num…
…py module
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| """Tests for :mod:`numpy.core.fromnumeric`.""" | ||
|
|
||
| import numpy as np | ||
|
|
||
| A = np.array(True, ndmin=2, dtype=bool) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| """Tests for :mod:`numpy.core.fromnumeric`.""" | ||
|
|
||
| import numpy as np | ||
|
|
||
| A = np.array(True, ndmin=2, dtype=bool) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| """Tests for :mod:`numpy.core.fromnumeric`.""" | ||
|
|
||
| import numpy as np | ||
|
|
||
| A = np.array(True, ndmin=2, dtype=bool) | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there's a better name than
fromnumeric.py? Maybe not though. At some point we're going to need to organize things better, but it's not hard to shuffle stuff around later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently it's named after the corresponding module in NumPy (
np.core.fromnumeric).I'm all ears if you have suggestions, but I feel that the current name is already pretty decent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im any case, I've added a module-level docstring to the tests for now to clarify that the relevant functions are from
np.core.fromnumeric(37cbded).