This repository was archived by the owner on Jun 10, 2020. It is now read-only.
MAINT: run black on all files in CI #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In numpy#63 black was run on `setup.py`. Follow up by running black on all files in CI. Do an inital pass over the entire codebase so that the CI check will pass.
person142
commented
Apr 21, 2020
| @@ -2,4 +2,6 @@ | |||
|
|
|||
| np.AxisError(1.0) # E: Argument 1 to "AxisError" has incompatible type | |||
| np.AxisError(1, ndim=2.0) # E: Argument "ndim" to "AxisError" has incompatible type | |||
| np.AxisError(2, msg_prefix=404) # E: Argument "msg_prefix" to "AxisError" has incompatible type | |||
| np.AxisError( | |||
| 2, msg_prefix=404 # E: Argument "msg_prefix" to "AxisError" has incompatible type | |||
There was a problem hiding this comment.
This is an interesting one where you do have to modify the output black gives you a bit because the exact line number matters. I don't think this should be a huge inconvenience going forward though.
|
This is fine with me, agreed that it's still early enough |
|
Ok, let's merge it then before it gets stale. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #63 black was run on
setup.py. Follow up by running black on all files in CI. Do an inital pass over the entire codebase so that the CI check will pass.I'm usually opposed to things like this, but it seems like we're in an early enough stage that it should be ok.