8000 MAINT: move __getattr__ to the top of __init__.pyi by person142 · Pull Request #62 · numpy/numpy-stubs · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

MAINT: move __getattr__ to the top of __init__.pyi #62

Merged
merged 1 commit into from
Apr 20, 2020
Merged

MAINT: move __getattr__ to the top of __init__.pyi #62

merged 1 commit into from
Apr 20, 2020

Conversation

person142
Copy link
Member
@person142 person142 commented Apr 19, 2020 •
edited
Loading

We have a

def __getattr__(name: str) -> Any: ...

since not everything is typed yet. It was originally at the bottom of
the __init__.pyi file, but has since ended up not at the end because
it's hard to remember to put your code above it. Since it makes sense
to have it somewhere more noticeable than the middle of the file, put
it at the top instead.

@person142
MAINT: move __getattr__ to the top of __init__.pyi
5c044bd 
We have a

```
def __getattr__(name: str) -> Any: ...
```

since not everything is typed yet. It was originally at the bottom of
the __init__.pyi file, but has since ended up not at the end because
it's hard to remember to put your code above it. Since it makes sense
to have it somewhere more noticeable than the middle of the file, put
it at the top instead.
@rgommers rgommers merged commit 83f7216 into numpy:master Apr 20, 2020
@rgommers
Copy link
Member

Makes sense, thanks, merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@person142 @rgommers
0