This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Add Python 3.8 to the CI matrix #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also required bumping the flake8 version.
person142
commented
Apr 18, 2020
| @@ -1,10 +1,12 @@ | |||
| language: python | |||
| matrix: | |||
| include: | |||
| - python: 3.8 | |||
| dist: xenial | |||
There was a problem hiding this comment.
Xenial is currently the default, but pinning it since it won't be the default forever.
person142
commented
Apr 18, 2020
| - python: 3.7 | ||
| dist: xenial | ||
| sudo: true |
There was a problem hiding this comment.
sudo: true is the default.
|
LGTM, merged. Thanks @person142 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also required bumping the flake8 version.
While experimenting with plugins in #56 I was getting CI failures on 3.7 but not 3.6, so it seemed prudent to expand our CI matrix.