8000 Added Warning and Exception annotations by BvB93 · Pull Request #57 · numpy/numpy-stubs · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Added Warning and Exception annotations #57

Merged
merged 3 commits into from
Apr 18, 2020
Merged

Added Warning and Exception annotations #57

merged 3 commits into from
Apr 18, 2020

Conversation

BvB93
Copy link
Member
@BvB93 BvB93 commented Apr 18, 2020 •
edited
Loading

See #54.

Added annotations and tests for:

Bas van Beek added 2 commits April 18, 2020 16:13
Implemented Warning and Exception annotations
2a1c59c 
See https://github.com/numpy/numpy-stubs/issues/54.

Added annotations and tests for:
* np.warnings
* np.ModuleDeprecationWarning
* np.VisibleDeprecationWarning
* np.ComplexWarning
* np.RankWarning
* np.TooHardError
* np.AxisError
Annotate using Python 2 compatible type comments
ba767a0
person142
person142 reviewed Apr 18, 2020
View reviewed changes
Copy link
Member
@person142 person142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I had a few comments (and black is unhappy), but it looks good!

Addressed comments from #57
ac0ce25 
* Removed ``warnings`` (#57 (comment))
* Deleted a now redundant comment (#57 (comment))
* Created and/or moved a number of tests to fail/ and reveal/ (#57 (comment) and #57 (comment))
* Formatted the main __init__.pyi file with black (#57 (review))
@BvB93
Copy link
Member Author
BvB93 commented Apr 18, 2020

Thanks for feedback! I've addressed your points in the latest push.

@person142 person142 merged commit 559ff04 into numpy:master Apr 18, 2020
@person142
Copy link
Member

Great, thanks @BvB93.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@person142 person142 person142 left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BvB93 @person142
0