8000 Add zip_safe=False to setup.py · Issue #36 · numpy/numpy-stubs · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Add zip_safe=False to setup.py #36

Closed
aldanor opened this issue Nov 21, 2019 · 1 comment · Fixed by #46
Closed

Add zip_safe=False to setup.py #36

aldanor opened this issue Nov 21, 2019 · 1 comment · Fixed by #46
Labels
bug

Comments

@aldanor
Copy link
aldanor commented Nov 21, 2019

... otherwise it doesn't work because it will be packed by setuptools.

It's even mentioned specifically in mypy docs: https://mypy.readthedocs.io/en/latest/installed_packages.html#making-pep-561-compatible-packages
@shoyer
Copy link
Member
shoyer commented Nov 21, 2019

Thanks for pointing this out. Any interest in putting together a PR?

person142 added a commit to person142/numpy-stubs that referenced this issue Mar 29, 2020
@person142
MAINT: set zip_safe to False in setup.py
697130a 
Closes numpy#36.

See the mypy docs:

https://mypy.readthedocs.io/en/latest/installed_packages.html#making-pep-561-compatible-packages

for more information.
@person142 person142 mentioned this issue Mar 29, 2020
Merged
@rgommers rgommers added the bug label Mar 29, 2020
rgommers pushed a commit that referenced this issue Mar 29, 2020
@person142
MAINT: set zip_safe to False in setup.py (#46)
0088d0f 
Closes #36.

See the mypy docs:

https://mypy.readthedocs.io/en/latest/installed_packages.html#making-pep-561-compatible-packages

for more information.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: set zip_safe to False in setup.py person142/numpy-stubs
3 participants
@rgommers @shoyer @aldanor
0