TST: linalg: add basic smoketest for cholesky #9796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Sep 30, 2017
| t[-2:] = -1, -2 | ||
|
|
||
| a = np.matmul(a.transpose(t).conj(), a) | ||
| a = np.asarray(a, dtype=dtype) |
There was a problem hiding this comment.
Out of curiousity, is the dtype actually needed here?
There was a problem hiding this comment.
Of course, numpy.linalg doesn't do anything apart from double precision, but better still to test all combinations.
|
Thanks Pauli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic smoke test for numpy.linalg.cholesky.
Apparently, there are currently no tests that check it actually
does something sensible, so stuff like gh-9795 can slip through
in a release. This is also a routine that's quite often broken in
broken openblas builds.
I checked this test fails on the current win32 32-bit wheel on pypi.