BUG: Errors thrown by 0d arrays in setitem are silenced and replaced #9752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Sep 23, 2017
| a_u[()] = np.ma.masked | ||
| assert_equal(a_u[()], u'--') | ||
|
|
||
| @dec.knownfailureif(True, "See gh-9750") |
98e6149 to
df79005
Compare
mhvk
reviewed
Sep 23, 2017
| @@ -36,6 +36,16 @@ | |||
| #include <limits.h> | |||
| #include <assert.h> | |||
|
|
|||
| /* check for sequences, but ignore the types numpy considers scalars */ | |||
| static NPY_INLINE npy_bool | |||
| MyPySequence_Check(PyObject *op) { | |||
There was a problem hiding this comment.
Instead of this, perhaps call it PySequence_NoString_Check? (Think it is fine not to mention the array scalar - that more obviously is not a sequence.)
|
The error now is something about not being able to convert masked constant to |
df79005 to
f61f65a
Compare
mhvk
reviewed
Sep 23, 2017
| @@ -36,6 +36,16 @@ | |||
| #include <limits.h> | |||
| #include <assert.h> | |||
|
|
|||
| /* check for sequences, but ignore the types numpy considers scalars */ | |||
| static NPY_INLINE npy_bool | |||
| PySequence_Check(PyObject *op) { | |||
There was a problem hiding this comment.
Forgot to change the name in its definition...
f61f65a to
8e26a5d
Compare
|
LGTM, thanks Eric, Marten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-8461