BUG: Inlined functions must be defined somewhere. #9446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some inline functions in numpy/core/src/multiarray/mapping.c were defined as `NPY_NO_EXPORT NPY_INLINE` with the result that gcc 7.1 was looking for an external definition. Possibly some of those functions were no longer being inlined. The fix was to replace `NPY_NO_EXPORT` with `static`. A grep of the numpy source files turned up no further uses of that unfortunate combination.
|
I'm going to put this in shortly unless someone complains. |
|
This doesn't belong in 1.13.2 - it's (my) regression in #8278, which is targeting 1.14. |
|
Thanks Chuck. As Eric said, this does not need to be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some inline functions in numpy/core/src/multiarray/mapping.c were
defined as
NPY_NO_EXPORT NPY_INLINEwith the result that gcc 7.1 waslooking for an external definition. Possibly some of those functions
were no longer being inlined. The fix was to replace
NPY_NO_EXPORTwith
static. A grep of the numpy source files turned up no furtheruses of that unfortunate combination.