MAINT: Simplify if statement #9168
Conversation
isinstance(obj, ndarray) will return False if (obj is None) in any case, so no need to check whether (obj is not None) before it. All tests pass on my build (the most recent one at the time making this PR). However, this might have been done for backward compatibility. Will see how the CI tests do.
|
In general, one has to be a bit careful, since the p.s. Might it be an idea to go through the file a bit more to look for more clean-up? |
|
Ah, I see. No problem - if I find anything else, just add it to this PR? |
|
Yes, indeed. But don't worry if you don't find more or don't really have time --little improvements are welcome too. (But even just getting that particular file to conform to PEP8 a bit better would be nice... it always looks squiggly red in my emacs window.) |
|
Ok, sure. I don't really look for these things explicitly, but I just notice things every now and then as I read through the source code and try to familiarize myself with it more. I normally submit the PRs immediately, otherwise I might forget! |
|
Thanks @k-kapp . |
isinstance(obj, ndarray)will returnFalseif(obj is None)in any case,so no need to check whether
(obj is not None)before it. All testspass on my build (the most recent one at the time of making this PR).
However, this might have been done for backward compatibility (CI tests all pass, though).