DEP: Deprecate np.ma.MaskedArray.mini
#8939
Conversation
fd2a854 to
5aaa820
Compare
5aaa820 to
b06c464
Compare
|
(appveyor was broken) |
|
This looks good to me. The only other place in which we may want to mention the reduce is the docstring of minimum, as an example. |
You mean the one at |
|
Right :)
|
|
☔ The latest upstream changes (presumably #8996) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Needs rebase. Maybe deal with comment. |
|
Is that |
This was untested, and the documentation did not mention how it differed from `min` anyway. Fixes numpy#8764
This shorthand is just inconsistent with `np.maximum`, and just makes the distinction between `np.ma.max` and `np.ma.maximum` even more confusing. Also adds names to these objects, since 1) they're there in core, and 2) they make the warning message more helpful.
98fdd0a to
411f682
Compare
|
Rebased, comment addressed. Kinda. Seems easiest just to copy across the |
Hmm. Looks like it does as the default behavior is changed. |
|
Mostly, I'm trying to get the deprecations in before branching 1.13. |
13073f5 to
43c2573
Compare
This does not match np.maximum, which is confusing because the masked version has no documentation at all. This uses a similar deprecation approach to numpygh-8918, noting that the warning is only needed for arrays of more than one dimension. The same remarks apply to `np.ma.minimum`
Introduced by me in numpy#8918
Also, remove unecessary subclasses
43c2573 to
156af61
Compare
|
Ok, respun as a deprecation, rather than an API-breaking bugfix |
|
Thanks Eric. |
np.ma.MaskedArray.mini
This was untested, and the documentation did not mention how it differed from
minanyway.Fixes #8764
Also (movable to another PR on request):
np.ma.minimum(x)as an alias fornp.ma.minimum.reduce, because this alias does not exist fornp.minimum(x)in core, and this makes the distinction betweenminimumandminconfusingnp.ma.minimum.reduce, which was different from that in core. (but not documented anywhere)