API: Change default axis argument for argsort. #8904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this is a breaking change. There's something to be said for Julian's position of "this ship has sailed", and also for making the user specify |
|
Ok, I'll leave this as is for when that "several releases" time comes. In the mean time, I've got a deprecating version at #8918 |
Only deprecated when this would be ambiguous. Approaches numpy#8701
Now matches: * its own documentation * everything else Fixes numpy#8701
|
☔ The latest upstream changes (presumably #8996) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing this, since it'll be easier just to make a new PR to remove this deprecation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now matches:
Fixes #8701
Should this be considered a breaking change? Do we want to go through a deprecation cycle that requires this argument to be specified explicitly when needed? Something like <snip> #8918
Continuing from a forgotten discussion with @juliantaylor at #8678 (comment)