8000 BUG: Move ctypes ImportError catching to appropriate place by davidjn · Pull Request #8898 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Move ctypes ImportError catching to appropriate place #8898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 7, 2017
Merged

BUG: Move ctypes ImportError catching to appropriate place #8898

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e273fb5
Move ctypes ImportError catching to appropriate place
davidjn Apr 5, 2017
69143e7
Add dummy_ctype to _internal.py and refactor some ctypes methods
davidjn Apr 6, 2017
c9fe3ba
BUG: Updating dummy_ctype's behavior.
davidjn Apr 6, 2017
b29ae31
Adding numpy/core/tests/test_internal.py.
davidjn Apr 7, 2017
bb56070
Add numpy import to _internal.py.
davidjn Apr 7, 2017
3af4fe5
BUG: move numpy import into _getintp_ctype
davidjn Apr 7, 2017
4e2ab70
BUG: Removing sys mangling from test_ctypes_is_not_available
davidjn Apr 7, 2017
bd3011e
Adding GetIntPCtypeTest and minor clean up
Apr 7, 2017
9b19671
Fixing GetIntPCtypeTest for x-platform
Apr 7, 2017
0e4942a
BUG: Use cache in _getintp_ctype, move tests.
Apr 7, 2017
82bebd2
_cyptes._arr.shape -> _ctypes.shape
davidjn Apr 7, 2017
647a75e
BUG: Fixing tests and actually udating _getintp_ctype to use cache.
Apr 7, 2017
e75a486
BUG: Fixing tests and actually udating _getintp_ctype to use cache.
Apr 7, 2017
06b3a82
BUG: Updates to TestCTypes test class.
Apr 7, 2017
2652a1e
BUG: list casting -> typle casting.
Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: Fixing tests and actually udating _getintp_ctype to use cache.
  • Loading branch information
David Nicholson committed Apr 7, 2017
commit 647a75eaa4c5d2c3d50002b18f88f3f800f49d6b
23 changes: 12 additions & 11 deletions numpy/core/_internal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,21 +208,22 @@ def __eq__(self, other):
return self._cls == other._cls

def _getintp_ctype():
if ctypes is None:
import numpy as np
return dummy_ctype(np.intp)
val = _getintp_ctype.cache
if val is not None:
return val
char = dtype('p').char
if (char == 'i'):
val = ctypes.c_int
elif char == 'l':
val = ctypes.c_long
elif char == 'q':
val = ctypes.c_longlong
if ctypes is None:
import numpy as np
val = dummy_ctype(np.intp)
else:
val = ctypes.c_long
char = dtype('p').char
if (char == 'i'):
val = ctypes.c_int
elif char == 'l':
val = ctypes.c_long
elif char == 'q':
val = ctypes.c_longlong
else:
val = ctypes.c_long
_getintp_ctype.cache = val
return val
_getintp_ctype.cache = None
Expand Down
17 changes: 7 additions & 10 deletions numpy/core/tests/test_multiarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
8000 Expand Up @@ -6729,24 +6729,21 @@ def test_null_inside_ustring_array_is_truthy(self):


class TestCTypes(TestCase):
def setUp(self):
self.test_arr = np.array([[1, 2, 3], [4, 5, 6]])

def test_ctypes_is_available(self):
_ctypes = np.array(self.test_arr).ctypes
test_arr = np.array([[1, 2, 3], [4, 5, 6]])

self.assertEqual(ctypes, _ctypes._ctypes)
assert_equal(_ctypes._arr.shape, (2, 3))
assert_array_equal(_ctypes._arr, self.test_arr)
self.assertEqual(ctypes, test_arr.ctypes._ctypes)
assert_equal(test_arr.shape, (2, 3))

def test_ctypes_is_not_available(self):
_internal.ctypes = None
try:
_ctypes = np.array(self.test_arr).ctypes
test_arr = np.array([[1, 2, 3], [4, 5, 6]])

self.assertIsInstance(_ctypes._ctypes, _internal._missing_ctypes)
assert_equal(_ctypes._arr.shape, (2, 3))
assert_array_equal(_ctypes._arr, self.test_arr)
self.assertIsInstance(
test_arr.ctypes._ctypes, _internal._missing_ctypes)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debatable whether testing implementation details like this (and the one above) makes any sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel strongly, I'll remove it. I think its a good check to keep. For instance, if someone decides to add an "import ctypes" statement into one of these methods in the future, this assertion will catch that. Otherwise, the test will continue to pass.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my concernt is that that's somewhat artificial, and doesn't really catch us doing import ctypes anywhere else - these tests wouldn't catch the bug that caused you to patch this in the first place, for instance.

I don't feel strongly about it, but would appreciate input from someone else on a better way to test this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Will wait for additional input.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm almost tempted to spin off a new python interpreter without ctypes to run the test, to ensure it can't break anything else

You might also be able to get your sys.modules hackery to work if you try to put everything back together again, but also a little risky.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Eric,

I tried again with the sys.modules hackery, and trying to put things back together again with the try/finally block. Unfortunately, other tests continue to fail. I guess this is because tests are run in parallel. With the current setup (setting ctypes = None), we will have similar cross-test side effects, but I guess we are getting lucky in that it isn't causing any errant failures.

By "spin off a new python interpreter", are you suggesting to execute the test with python's subprocess?

Eg (?):
def some_test(self):
self.assertEqual(0, subprocess.call(sys.executable, "-c", test_code)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting to execute the test with python's subprocess?

Yes, that is what I mean. I'm not actually sure that's a good idea though, and I don't think you should risk wasting time trying it until someone else weighs in.

assert_equal(test_arr.shape, (2, 3))
Copy link
Member
@eric-wieser eric-wieser Apr 7, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be test_arr.ctypes.shape. We specifically need to test the ctypes shape, not the normal one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion here, updating in the next commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

finally:
_internal.ctypes = ctypes

Expand Down
385B
0