BUG: Don't modify types after PyType_Ready #8888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that 9bcc664 already knew about this problem, but forgot to fix it in both places |
This would previously cause hashing to work even though `__hash__` is None. Fixes numpy#8887
3efbe1f to
17909cc
Compare
|
+1, I independently came up with the same fix for #8887. |
|
are there more cases of this? this would be the third fix of this kind, still a nice find. |
|
from a quick glance only |
|
|
|
oh yeah, FloatInt != Float ... |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would previously cause hashing to work even though
__hash__is None.Fixes #8887