8000 BUG: fix nanpercentile not returning scalar with axis argument by charris · Pull Request #8371 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: fix nanpercentile not returning scalar with axis argument #8371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BUG: fix nanpercentile not returning scalar with axis argument #8371

wants to merge 1 commit into from

Conversation

charris
Copy link
Member
@charris charris commented Dec 12, 2016

Backport of #8366.

Closes gh-8220

Example of bug:

In [5]: np.nanpercentile(a, 50, axis=0)
Out[5]: array(2.5)

The result should be a scalar, not a scalar array.

@juliantaylor
Copy link
Contributor

hm I added that to the other backport

@charris
Copy link
Member Author
charris commented Dec 12, 2016

Well, OK, I'll close this. Since the log included in the release notes is organized by PR, I think it generally best to have separate fixes in separate PRs.

@charris charris closed this Dec 12, 2016
@charris charris deleted the backport-8366 branch December 12, 2016 23:40
@juliantaylor
Copy link
Contributor

does the log include the backport PR or the original PR?
I guess an argument can be made for both in the former you can summarize the issue in the latter you don't have to repeat and have less PRs.

@juliantaylor
Copy link
Contributor

I can remove this change from the other backport if you prefer.

@charris
Copy link
Member Author
charris commented Dec 13, 2016

It includes the backport PR, which is one reason I include a link to the original in the backport. Don't bother with the fix, it isn't that big a deal and I edited the PR title to reflect both fixes.

@charris
Copy link
Member Author
charris commented Dec 13, 2016

I note that scipy has been collecting the backports into a single merge, but I still prefer to keep them separate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug 08 - Backport Used to tag backport PRs component: numpy.lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charris @juliantaylor
0