BUG: Fix ndarray.tofile large file corruption in append mode #8335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works 8000 for me. @juliantaylor Comment? |
juliantaylor
reviewed
Dec 4, 2016
| @@ -46,7 +46,7 @@ npy_fallocate(npy_intp nbytes, FILE * fp) | |||
| } | |||
| /* btrfs can take a while to allocate making release worthwhile */ | |||
| NPY_BEGIN_ALLOW_THREADS; | |||
| r = fallocate(fileno(fp), 0, npy_ftell(fp), nbytes); | |||
| r = fallocate(fileno(fp), 1, npy_ftell(fp), nbytes); | |||
There was a problem hiding this comment.
should have a comment that this is FALLOC_FL_KEEP_SIZE needed for the case of files opened in append mode
|
might be a good idea to flush the file descriptor too, in case there might be some unexpected interactions between the call and unwritten data in the descriptor. |
|
a test writing two arrays to an append mode file would also be good, similar to the above test but without the seek. |
|
@juliantaylor I added a |
|
yes, thank you. Can you still squash the two commits please. |
…append file mode Fixes by using the flag `FALLOC_FL_KEEP_SIZE` (=1) in the `fappend` call. Fixes #8329
|
Sure, done. |
|
thanks |
This was referenced Dec 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes by using the flag
FALLOC_FL_KEEP_SIZE(=1) in thefappendcall.Fixes #8329