BUG: Fix array printing with precision=0. #8107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
Oct 6, 2016
| z = s.rstrip('0') | ||
| return precision - len(s) + len(z) | ||
| else: | ||
| return len(s) |
There was a problem hiding this comment.
Shouldn't it just return zero? In the non-zero case there is a decimal point that stops the rstrip so the precision returned is the actual number of digits past the decimal point minus trailing zeros. In the zero case that would always be zero if the decimal point was still there.
There was a problem hiding this comment.
Oh, definitely, thank you for the careful look.
charris
reviewed
Oct 6, 2016
| @@ -129,6 +129,13 @@ def test_basic(self): | |||
| np.set_printoptions(precision=4) | |||
| assert_equal(repr(x), "array([ 1.5 , 0. , 1.2346])") | |||
|
|
|||
| def test_precision_zero(self): | |||
| np.set_printoptions(precision=0) | |||
| x = np.array([0, .7, 1.5, -1.5]) | |||
There was a problem hiding this comment.
You need some examples like 100.0.
Values rounding to zero were formatted with negative precision.
954bf5d to
65e1e0e
Compare
|
Changed |
|
Thanks @wrwrwr . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a particularly significant matter, but trying something as follows:
results in:
This is easily fixed by handling the case of rounding to integers when counting significant digits.
I've also included instances of ties-to-even rounding in the test case, after the docstring for rint(), but maybe that's too specific (IEEE 754 defines more rounding modes).