DOC: Fix for issue #7701 #8023
Closed
DOC: Fix for issue #7701 #8023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -906,7 +906,7 @@ The ``code.c`` file also contains the function ``dfilter2d``: | |||
| a has strides that are multiples of sizeof(double) | |||
| */ | |||
| void | |||
| dfilter2d(double *a, double *b, int *astrides, int *dims) | |||
| dfilter2d(double *a, double *b, int *astrides, ssize_t *dims) | |||
There was a problem hiding this comment.
astrides should also be of ssize_t type. And there is not much benefit in modifying the type of the function parameter if inside the function you still use M and N (and S0 and S1 once astrides is also changed) as ints.
|
Made the needed fixes in an upcoming PR, so closing this. Thanks @souravsingh . |
charris
added a commit
to charris/numpy
that referenced
this pull request
Nov 5, 2016
Corrections to numpy#8023. - Fix index types to ssize_t. - Clean up C code style. Closes numpy#7701. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #7701