DOC: Corrected allowed keywords in add_(installed_)library #7979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docstring listed extra_f77_compiler_args and extra_f90_compiler_args as allowed keywords, but per command/build_clib.py, lines 193-194 the recognized keywords are in fact extra_f77_compile_args and extra_f90_compile_args. The keyword extra_compiler_args, although non-confirmant both for fortran keywords and to the keywords of add_extension, is consistent with the implementation (see line 200 of build_clib.py).
|
I think we should add the option for the other version too at some point, but it isn't obvious how to do that at first look. The lines that your post referenced use local variables that are set elsewhere... |
|
Thanks @oleksandr-pavlyk , this should help others relying on the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstring listed
extra_f77_compiler_argsandextra_f90_compiler_argsas allowed keywords of
add_libraryandadd_installed_libraryofnumpy.disutils,but per
command/build_clib.py, lines 193-194the recognized keywords are in fact
extra_f77_compile_argsandextra_f90_compile_args.The keyword
extra_compiler_args, although non-confirmant both forFortran keywords and to the keywords of add_extension, is consistent
with the implementation (see line 200 of
build_clib.py).See short discussion at
https://mail.scipy.org/pipermail/numpy-discussion/2016-August/075904.html