8000 BUG: Use keyword arguments to initialize Extension base class. by charris · Pull Request #7952 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: Use keyword arguments to initialize Extension base class. #7952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2016
Merged

BUG: Use keyword arguments to initialize Extension base class. #7952

merged 1 commit into from
Aug 20, 2016

Conversation

charris
Copy link
Member
@charris charris commented Aug 20, 2016

Currently numpy.distutils.Extension class subclasses python's
distutils.extension.Extension class and initializes the base class with
a call that uses positional arguments rather than keyword arguments.
This causes problems with setuptools 25.4.0 where the Extension class
gets a new init function that expects keyword rather than positional
arguments. We should have been using keyword arguments all along and our
luck has run out, so use proper keywords

Closes #7951.

@charris
BUG: Use keyword arguments to initialize Extension base class.
f3b8ef0 
Currently numpy.distutils.Extension class subclasses python's
distutils.extension.Extension class and initializes the base class with
a call that uses positional arguments rather than keyword arguments.
This causes problems with setuptools 25.4.0 where the Extension class
gets a new init function that expects keyword rather than positional
arguments. We should have been using keyword arguments all along and our
luck has run out, so use proper keywords

Closes numpy#7951.
@charris charris added this to the 1.11.2 release milestone Aug 20, 2016
@rgommers rgommers merged commit 86960c2 into numpy:master Aug 20, 2016
@rgommers
Copy link
Member

Merged, thanks Chuck.

@charris charris mentioned this pull request Aug 20, 2016
Merged
@charris charris removed this from the 1.11.2 release milestone Aug 20, 2016
@charris charris deleted the fix-for-setuptools_25_4 branch August 21, 2016 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug component: numpy.distutils
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charris @rgommers
0