BUG: Make sure numpy globals keep identity after reload. #7941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45803b9 to
5b12784
Compare
| ] | ||
|
|
||
|
|
||
| # Disallow reloading numpy. Doing that does nothing to change previously |
There was a problem hiding this comment.
Update comment here to say disallow reloading _globals
|
This looks good to me. Only thing to do would seem to be to update the comments in the new |
Reloading currently causes problems because global classes defined in numpy/__init__.py change their identity (a is b) after reload. The solution taken here is to move those classes to a new non-reloadable module numpy/_globals and import them into numpy from there. Classes moved are ModuleDeprecationWarning, VisibleDeprecationWarning, and _NoValue. Closes numpy#7844.
5b12784 to
0ade4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that pandas, matplotlib, and astropy all reload numpy, the preferred solution of raising and error when a reload is attempted is too draconian. This PR takes the approach of making numpy reload safer by moving the needed globals into their own
_globals.pymodule from which they can be imported when numpy reloads. Unless_globals.pyitself is reloaded, not just imported from, the identity of the globals will remain intact.