8000 BUG: fix float16 type not being called due to wrong ordering by juliantaylor · Pull Request #7903 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: fix float16 type not being called due to wrong ordering #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2016

Conversation

juliantaylor
Copy link
Contributor

closes gh-7897

@juliantaylor
Copy link
Contributor Author

doesn't fix the ugliness in scalarmath, maybe someone has good idea how to do this

@juliantaylor
Copy link
Contributor Author
juliantaylor commented Aug 4, 2016

interestingly pow does test this, I ran into this in my exp,log,sin,cos,pow vectorization branch too

*/
i = 4;
j = 2;
i = 6;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha... Boy, that is ugly ;)

@charris charris merged commit bfd91d9 into numpy:master Aug 5, 2016
@charris
Copy link
Member
charris commented Aug 5, 2016

Thanks Julian.

@charris charris added this to the 1.11.2 release milestone Aug 5, 2016
@charris
Copy link
Member
charris commented Aug 5, 2016

I've been thinking of getting rid of the ufuncs in scalarmath and just using the npymath lib. I already got rid of some of the ufuncs for divmod, just didn't finish the job.

@charris charris removed this from the 1.11.2 release milestone Aug 5, 2016
@juliantaylor juliantaylor deleted the sqrt-type-fix branch August 5, 2016 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

np.sqrt.types is bogus
2 participants
0