ENH: Add multidimensional array support to numpy.random.choice #7810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards compatible by adding an `axis` keyword to the end of the signature for choice. Default is 0, which selects by row. The default keyword arguments make it functionally equivalent to random.choice from Python's standard library. Note, however, that a list of tuples will have the tuples returned as lists. Issue numpy#2724 was originally opened with that request, but numpy#2727 seems to have closed it accidentally.
|
Any movement on this? |
bashtage
added a commit
to bashtage/randomgen
that referenced
this pull request
Apr 12, 2019
Add axis to choice xref numpy/numpy#7810
bashtage
added a commit
to bashtage/randomgen
that referenced
this pull request
Apr 12, 2019
Add axis to choice xref numpy/numpy#7810
bashtage
added a commit
to bashtage/randomgen
that referenced
this pull request
Apr 12, 2019
Add axis to choice xref numpy/numpy#7810
bashtage
added a commit
to bashtage/numpy
that referenced
this pull request
Apr 13, 2019
Improve performance in all cases Large improvement with size is small xref numpy#5299 xref numpy#2764 xref numpy#9855 xref numpy#7810
16 tasks
mattip
pushed a commit
to mattip/numpy
that referenced
this pull request
May 20, 2019
Improve performance in all cases Large improvement with size is small xref numpy#5299 xref numpy#2764 xref numpy#9855 xref numpy#7810
mattip
pushed a commit
to mattip/numpy
that referenced
this pull request
May 20, 2019
Improve performance in all cases Large improvement with size is small xref numpy#5299 xref numpy#2764 xref numpy#9855 xref numpy#7810
|
Closing, |
8000
|
Great news! Which version should it be released with? |
|
1.17 (the next major release), if we don't discover a problem and have to revert it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible by adding an
axiskeyword to the end of thesignature for choice. Default is 0, which selects by row. The default
keyword arguments make it functionally equivalent to random.choice from
Python's standard library. Note, however, that a list of tuples will
have the tuples returned as lists.
Issue #2724 was originally opened with that request, but #2727 seems to
have closed it accidentally.