ENH: Do not check the type of module.__dict__ explicit in test. #7668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is for Pyston compatibility. In Pyston, the type of module.__dict__ is attrwrapper, which is a dict like type. The test in here is not really care for particular type, but instead cares for particular behaviour. So change the expilit type check to a interface check. This check can also get passed in CPython and PyPy
|
LGTM. @njsmith Thoughts? |
|
Thanks @Daetalus . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is for Pyston compatibility. In Pyston, the type of
module.__dict__is attrwrapper, which is a dict like type. The test in here is not really care
for particular type, but instead cares for particular behaviour. So change the
expilit type check to a interface check. This check can also get passed in CPython and PyPy.
@njsmith