8000 DOC: RST definition list fixes by endolith · Pull Request #7626 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

DOC: RST definition list fixes #7626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2016
Merged

DOC: RST definition list fixes #7626

merged 2 commits into from
May 12, 2016

Conversation

endolith
Copy link
Contributor

also add a more obvious example to the HOWTO

@charris
Copy link
Member
charris commented May 12, 2016

What happens if the colon is left in? Note that we don't use rst, the docstring format is converted before rendering and I wonder if that should be fixed to work with the colon all the time. Also, note the commit message formatting documented in doc/source/dev/gitwash/development_workflow.rst

@pv Thoughts?

@endolith
Copy link
Contributor Author
endolith commented May 12, 2016

What happens if the colon is left in?

It's not rendered as a definition list anymore, such as message and explain here:

http://docs.scipy.org/doc/scipy/reference/generated/scipy.integrate.quad.html#scipy.integrate.quad

or in Numpy docs it adds an extraneous colon:

residuals, rank, singular_values, rcond : :

http://docs.scipy.org/doc/numpy-dev/reference/generated/numpy.polyfit.html

There should only be a colon if there's a classifier after it. The indentation is what makes it a definition list, not the colon:

http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#definition-lists

endolith added 2 commits May 11, 2016 20:41
Definition lists are marked up with indentation, not colons, and extra
colons break the web formatting
@charris
Copy link
Member
charris commented May 12, 2016

@endolith My point was that the docstrings are not rst, so another place a fix could be made would be in numpydoc, which presumably could be modified to handle the empty string after the colon. That's why I pinged @pv.

@pv
Copy link
Member
pv commented May 12, 2016 via email

@charris charris merged commit e209a18 into numpy:master May 12, 2016
@charris
Copy link
Member
charris commented May 12, 2016

Thanks @endolith .

@charris
Copy link
Member
charris commented May 12, 2016

I opened an issue for numpydoc.

@endolith endolith deleted the patch-1 branch May 12, 2016 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0