-
-
Notifications
You must be signed in to change notification settings - Fork 11k
TST: fix #6542, add tests to check non-iterable argument raises in hstack and related functions. #7342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should allow for some tests that require `pytz` to run during CI.
...to hstack, vstack, and stack
...for hsplit, vsplit, dsplit, dstack
TST: Install `pytz` in the CI.
DOC: Fixed math rendering in tensordot docs.
DOC: Fix more typos in docs and comments.
Changed title to add hash to ticket number so that it links correctly. |
The MaskedArray.data attribute is unreliable for tests because it can contain arbitraty junk data at masked positions. Instead, all MaskedArray tests should look at marr.filled(0) to check if we got the same result.
This is just me being OCD. I am not sure this even merits a full commit, much less a PR, but here goes anyway.
Maint: Removed extra space from `ureduce`
|
||
def test_0D_array(self): | ||
a = np.array(1) | ||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right, what are you testing? Why catch the exception? Same below.
TST: Fix some MA tests to avoid looking at the .data attribute
MAINT: Hide nan warnings for masked internal MA computations
This test exposes padding bug described in the issue numpy#7353
Constant padding on 4 sides of a 2d array expected a numpy ndarray, and not a ndarray like (tuple, list, ...) Detailed description is in the issue numpy#7353
BUG: pull request related to the issue numpy#7353
...to hstack, vstack, and stack
...for hsplit, vsplit, dsplit, dstack
...use assert_raises() instead of catching the exception itself.
...of https://github.com/gkBCCN/numpy into bug-fix-6542 Conflicts: numpy/lib/tests/test_shape_base.py
I think you need to start over here. First, you are working off master, which is a no-no and probably why you now have 21 commits in this PR. Make a branch from master in work in that. It is possible that your master branch is now out of sync with the numpy repo, so you might want redo you own repo. You can also I'm going to close this. Please make another PR. |
Collaboration with @clauslang, @ClaudiaWinklmayr, @Zukkini:
-test that calls to hstack, vstack, stack, hsplit, vsplit, dsplit, dstack with non-iterable inputs raise errors