ENH: Make _pointer_type_cache functional #7311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #2303 Cache queries wont miss because the whole tuple is cached as key and not just dtype Adapted from patch submitted by Colin Hogben
|
Looks fine to me; thanks @udiboy1209! |
njsmith
added a commit
that referenced
this pull request
Feb 23, 2016
[PATCH] Make _pointer_type_cache functional
eric-wieser
added a commit
to eric-wieser/numpy
that referenced
this pull request
Nov 20, 2018
Fixes an alarming bug introduced in numpygh-7311 (1.12) where the following is true np.ctypeslib.ndpointer(ndim=2) is np.ctypeslib.ndpointer(shape=2) Rework of numpygh-11536
|
This patch introduced a pretty alarming bug (fixed in #12424): >>> from numpy.ctypeslib import ndpointer
>>> ndpointer(ndim=2) is ndpointer(shape=2)
True |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2303
Cache queries wont miss because the whole tuple is cached as key and not just dtype
Adapted from patch submitted by Colin Hogben