8000 BUG: Preserve array order in np.delete by gfyoung · Pull Request #7274 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

BUG: Preserve array order in np.delete #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2016
Merged

BUG: Preserve array order in np.delete #7274

merged 1 commit into from
Feb 19, 2016

Conversation

gfyoung
Copy link
Contributor
@gfyoung gfyoung commented Feb 18, 2016

Title is self-explanatory. Closes #7113.

@gfyoung
Copy link
Contributor Author
gfyoung commented Feb 19, 2016

Tests are passing. Should be good to merge if there are no complaints.

@njsmith
Copy link
Member
njsmith commented Feb 19, 2016

LGTM, thanks!

njsmith added a commit that referenced this pull request Feb 19, 2016
BUG: Preserve array order in np.delete
@njsmith njsmith merged commit 6d3b34f into numpy:master Feb 19, 2016
@njsmith
Copy link
Member
njsmith commented Feb 19, 2016

(Note for the record: I was initially a little thrown by the style of computing the array order explicitly and then doing arr.copy(order=arrorder) instead of just arr.copy(order="K"), but there's a bunch of other code in the same functions that already uses this arrorder thing on other paths, including ones where it couldn't be removed so easily, so the current patch seems fine to me.)

@gfyoung gfyoung deleted the delete_copy_dtype branch February 19, 2016 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0