BUG: only benchmark complex256 if it exists #7251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only benchmark complex256 type if numpy has it (MSVC windows builds do not).
cc9cabd to
73a2dc4
Compare
Memmap test can fail if run from a directory for which we don't have write permission. Avoid NamedTemporaryFile because of problems reopening files on Windows.
73a2dc4 to
3048fa4
Compare
|
Some discussion happened here and somehow got lost in the fog of github: matthew-brett@cc9cabd Anyway, I guess this is good to go, thanks @matthew-brett |
njsmith
added a commit
that referenced
this pull request
Feb 15, 2016
BUG: only benchmark complex256 if it exists
Sign up for
5804
free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only benchmark complex256 type if numpy has it (MSVC windows builds do
not).