8000 MRG: allow distributors to run custom init by matthew-brett · Pull Request #7231 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MRG: allow distributors to run custom init #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2016
Merged

MRG: allow distributors to run custom init #7231

merged 2 commits into from
Mar 8, 2016

Conversation

matthew-brett
Copy link
Contributor

Give hook to allow platform-specific installs to modify the
initialization of numpy. Particular use-case is to allow check for SSE2
on Windows when shipping with ATLAS wheel.

@matthew-brett matthew-brett mentioned this pull request Feb 11, 2016
Closed
@njsmith
Copy link
Member
njsmith commented Feb 11, 2016

I'd make it import ._distributor_init -- both for the clearer name, and because there's no reason to do import * and pollute the namespace. But otherwise I like the idea and had been thinking of proposing it too :-)

@matthew-brett
Copy link
Contributor Author

OK - I changed it as you suggested.

@njsmith
Copy link
Member
njsmith commented Feb 12, 2016

LGTM. But I'll leave this open for others to comment... in fact it might be useful to send an email to the list, and/or CC'ing our major known distributors like @cgohlke and Sandro.

@rgommers
Copy link
Member

@rkern's suggestion of unconditional import of an empty numpy/_distributor_init.py seems to be slightly more optimal, but other than that +1

@matthew-brett matthew-brett changed the title WIP: one way we could let builders modify init MRG: allow distributors to run custom init Feb 13, 2016
@matthew-brett
Copy link
Contributor Author

OK - modified as Robert suggested.

@charris
Copy link
Member
charris commented Feb 13, 2016

Needs mention in the 1.12 release notes

@charris charris added the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Feb 13, 2016
@homu
Copy link
Contributor
homu commented Feb 14, 2016

☔ The latest upstream changes (presumably #7246) made this pull request unmergeable. Please resolve the merge conflicts.

@charris
Copy link
Member
charris commented Feb 21, 2016

Needs rebase also...

@charris charris removed the 56 - Needs Release Note. Needs an entry in doc/release/upcoming_changes label Mar 7, 2016
@charris
Copy link
Member
charris commented Mar 7, 2016

@matthew-brett Needs rebase, probably the release notes.

@matthew-brett
ENH: platform-specific install hook to change init
9d6cdc1 
Give hook to allow platform-specific installs to modify the
initialization of numpy.  Particular use-case is to allow check for SSE2
on Windows when shipping with ATLAS wheel.
@matthew-brett
DOC: description of _distribution_init for release
2932da9 
Add description of ``numpy/_distribution_init.py`` file and init hook to
release notes for 1.12.0.
@matthew-brett
Copy link
Contributor Author
matthew-brett commented Mar 8, 2016 via email

charris added a commit that referenced this pull request Mar 8, 2016
@charris
Merge pull request #7231 from matthew-brett/local-init
b92cc76 
MRG:  allow distributors to run custom init
@charris charris merged commit b92cc76 into numpy:master Mar 8, 2016
@cgohlke cgohlke mentioned this pull request Jul 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - Enhancement component: distribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthew-brett @njsmith @rgommers @charris @homu
0