8000 DOC: add vstack, hstack, dstack reference to stack documentation. by aukejw · Pull Request #7191 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

DOC: add vstack, hstack, dstack reference to stack documentation. #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
DOC: add vstack, hstack, dstack reference to stack documentation.
  • Loading branch information
aukejw committed Feb 5, 2016
commit 512a820c6e02dfecb757bc5b01397ff8168847dc
5 changes: 5 additions & 0 deletions numpy/core/shape_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,11 @@ def stack(arrays, axis=0):
See Also
--------
concatenate : Join a sequence of arrays along an existing axis.
vstack : Stack arrays in sequence vertically, along the existing row axis.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in sequence" is superfluous; "the existing" should be "an existing". Same applies to the other three additions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right about 'in sequence', I'll remove it -- it'll also fit on one line that way. There is only one 'row axis' though?

hstack : Stack arrays in sequence horizontally, along the existing
column axis.
dstack : Stack arrays in sequence depth wise, along the existing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure that "depthwise" is one word in this context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, should I change that in vstack, hstack as well then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, I would say yes, unless someone really likes it the old way and disagrees.

third axis.
split : Split array into a list of multiple sub-arrays of equal size.

Examples
Expand Down
0