8000 Backport 7131 by charris · Pull Request #7132 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Backport 7131 #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2016
Merged

Backport 7131 #7132

merged 2 commits into from
Jan 28, 2016

Conversation

charris
Copy link
Member
@charris charris commented Jan 27, 2016

Backport #7131, Fix setuptools sdist

@charris charris added this to the 1.11.0 release milestone Jan 27, 2016
@charris
Copy link
Member Author
charris commented Jan 27, 2016

The cause of the failing tests is likely this

pip install --upgrade "pip<8.0.0" "setuptools<19.0"

Looks like we need later pip or setuptools, but they don't support 2.6,3.2, and 3.3. I'm inclined to remove the test from this backport.

@njsmith
Copy link
Member
njsmith commented Jan 27, 2016

Maybe we just need an earlier virtualenv?

@njsmith
Copy link
Member
njsmith commented Jan 27, 2016

(If these kinds of things continue to be a pain then it wouldn't be the end of the world to just drop 2.6/3.2/3.3 for 1.11. definitely it's nice to give people advance warning but getting stuck on 1.10 is not really any different than getting stuck on 1.11 for most people, I think.)

@charris
Copy link
Member Author
charris commented Jan 27, 2016

Checking if things work apart from known fails with current setuptools and pip.

@njsmith Has virtualenv changed recently?

@njsmith
Copy link
Member
njsmith commented Jan 27, 2016

I'm just guessing based on the fact that it's the virtualenv call that's
failing, and the traceback seems to reference an embedded copy of pip
8.something inside a directory called virtualenv_support.

On Wed, Jan 27, 2016 at 3:31 PM, Charles Harris notifications@github.com
wrote:

Checking if things work apart from known fails with current setuptools and
pip.

@njsmith https://github.com/njsmith Has virtualenv changed recently?

—
Reply to this email directly or view it on GitHub
#7132 (comment).

Nathaniel J. Smith -- https://vorpus.org http://vorpus.org

@charris
Copy link
Member Author
charris commented Jan 27, 2016

Looks like virtualenv was upgraded about a week ago (14.0.0 & 14.0.1).

@charris charris force-pushed the backport-7131 branch 3 times, most recently from 9514547 to 3fd93d1 Compare January 28, 2016 00:23
@rgommers
Copy link
Member

Just remove the commit with the test I'd say. There's not much value in backporting that.

Ralf Gommers added 2 commits January 28, 2016 08:25

@charris
BLD/BUG: revert usage of setuptools when building an sdist.
7f5efd1 
This was seriously broken.  Setuptools does unwanted 'smart' things and
ignores MANIFEST.in.  Closes numpygh-7127.
@charris
MAINT: warn in egg_info command if using setuptools.sdist.
dae1a38 
Warn in numpy/distutils/command/egg_info.py if using setuptools.sdist.

See numpygh-7127 for details.
@charris
Copy link
Member Author
charris commented Jan 28, 2016

@rgommers I was going to remove the versioning and Python 3.2 test, but removing the sdist test is just as easy.

charris added a commit that referenced this pull request Jan 28, 2016
@charris
Merge pull request #7132 from charris/backport-7131
7955bc8 
Backport 7131
@charris charris merged commit 7955bc8 into numpy:maintenance/1.11.x Jan 28, 2016
@charris charris deleted the backport-7131 branch January 28, 2016 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
06 - Regression 08 - Backport Used to tag backport PRs component: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charris @njsmith @rgommers
0