MAINT: Removed conditionals that are always false in datetime_strings.c #7102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you ellaborate on why negative values are not possible? |
| @@ -484,7 +484,7 @@ parse_iso_8601_datetime(char *str, Py_ssize_t len, | |||
| if (sublen >= 2 && isdigit(substr[0]) && isdigit(substr[1])) { | |||
| out->hour = 10 * (substr[0] - '0') + (substr[1] - '0'); | |||
There was a problem hiding this comment.
substr[0] and substr[1] are char digits (isdigit), of which '0' is the smallest, so out->hour can only be as small as 10 * 0 + 0 = 0
|
LGTM. One of the fixes looks like it also fixes a cut and paste error. |
charris
added a commit
that referenced
this pull request
Jan 29, 2016
MAINT: Removed conditionals that are always false in datetime_strings.c
|
Thanks @kawochen . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These conditionals always evaluate to
0.