BUG: Enforce Order Param for MaskedArray Construction #6912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this good to merge? Does someone want to take a look at this? Did I miss any other places where I should include/enforce the |
| x = MaskedArray(data, mask=nomask, dtype=None, | ||
| copy=False, subok=True, ndmin=0, fill_value=None, | ||
| x = MaskedArray(data, mask=nomask, dtype=None, copy=False | ||
| order=None, subok=True, ndmin=0, fill_value=None, |
There was a problem hiding this comment.
Should add the new parameter at the end just on general principles.
|
@charris : Changes have been made, and Travis and Appveyor are still happy. |
|
Could you add a mention in |
Adds the 'order' parameter to the __new__ override in MaskedArray construction, enabling it to be enforced in methods like np.ma.core.array and np.ma.core.asarray. Closes gh-6646.
|
@charris : Added mention in release notes. |
charris
added a commit
that referenced
this pull request
Jan 15, 2016
BUG: Enforce Order Param for MaskedArray Construction
|
Thanks @gfyoung . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue in #6646 in which the
orderparameter was not being enforced. This PR adds theorderparameter to the__new__override inMaskedArrayconstruction, enabling it to be enforced in methods likenp.ma.core.arrayandnp.ma.core.asarray.