Deploy dev wheels to rackspace from travis #6768
Conversation
| $PIP install --pre --no-index --upgrade --find-links=. numpy | ||
| $PIP install nose | ||
| pip install --pre --use-wheel --no-index --upgrade --find-links=. numpy | ||
| pip install nose |
There was a problem hiding this comment.
the --use-wheel option is actually not required but it does not hurt either. The pip command should be taken from the currently activate virtualenv instead of the $PIP env.
There was a problem hiding this comment.
--no-use-wheel is deprecated in pip 8.0, and --use-wheel isn't even listed in the help text of pip install anymore. So I wouldn't add it.
|
BTW, initially I wanted to have this build run on python nightly but the tests are currently broken as reported in #6764. |
|
Awesome, thanks! Does it upload unconditionally, or only if the tests pass? (This wasn't immediately obvious to me from just the diff.) Probably the latter is better, so that if we break things downstream folks won't see it :-) Not sure we really need to know the unencrypted secret, since if we ever change the wheelhouse password then we'll need to reencrypt anyway, but if you want to send it around then I guess the steering council is the group to send it to. |
|
It's after the |
|
Not sure, but my guess is that it does not work like that? The exit status of the test script is important, so either you check the exit value after run_test, or which may be a bit cleaner, we just add the if into the |
|
I could also move the upload code in the |
|
moving to |
|
Very nice, thanks Olivier! |
04be698 to
fa14458
Compare
fa14458 to
27abfb4
Compare
|
Comments addressed! |
|
LGTM. For this to actually make a difference, we also need to convince downstream projects to start using this wheel in their travis configurations :-). Do you think you could send around an email explaining how to do that and why it's a good idea? |
Deploy dev wheels to rackspace from travis
|
It works: the merge commit just pushed a new version of the dev wheel: http://66ce22ef0bf26a5e2cca-4ffdece11fd3f72855e4665bc61c7445.r49.cf2.rackcdn.com/index.html
I will soon work on a PR to do it for scipy if @rgommers or someone else does not do it before me. Then it's going to be easier for other downstream projects to replicate what's done for scipy. I am at conference right now so it I might do it slowly though. |
|
If this uploads on merge, might that not cause a problem when 1.11 is branched? At that point we will be merging to two branches. |
|
The upload is protected by an |
PR numpy#6768 introduced the uploading of wheels built during travisCI testing to a Rackspace account. We are moving away from Rackspace and already produce more complete sets of wheels for development testing on a weekly schedule. Consequently those wheels are not longer useful.
This is a fix for #6493. The python 3.5 build with the
USE_WHEEL=1option is now configured to upload a timestamped dev wheel to a public rackspace file container so that downstreams projects like scipy and scikit-learn can configure their own CI to test against the master branch of numpy without having to build it from source them-selves.wheelhouse_uploader>=0.9 automatically timestamps the local segment of the version of any wheel file it uploads to make it possible for pip to download the last uploaded dev version of the project. Only the 5 last uploaded dev wheels for a given platform are kept on the rackspace container.
The
tools/travis-test.shscript will only try to upload the wheels generated from the master branch, outside of any pull request (that is, only on travis builds triggered from merge commits in the master branch).The rackspace API key for the user account
travis.numpyis encrypted with the public key of thegithub.com/numpy/numpyrepo using thetravis encrypt -r numpy/numpy WHEELHOUSE_UPLOADER_SECRET=deadbeefcafebabecommand. I can send the rackspace credentials to a few numpy maintainers by private emails if you wish to change those credentials later.I tested it on my ogrisel/numpy travis account (with a different secure key) and it worked:
http://66ce22ef0bf26a5e2cca-4ffdece11fd3f72855e4665bc61c7445.r49.cf2.rackcdn.com/index.html
cc @njsmith @stefanv