8000 TST: only test f2py, not f2py2.7 etc, fixes #6718 by joernhees · Pull Request #6756 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

TST: only test f2py, not f2py2.7 etc, fixes #6718 #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2015

Conversation

joernhees
Copy link
Contributor

see #6718 for discussion

@charris
Copy link
Member
charris commented Dec 2, 2015

Apparently f2py is also missing sometimes. Hmm..., maybe try in order?

@joernhees
Copy link
Contributor Author

i extended the test so it falls back to the old version of the test and only fails if none works...

that said i'm not entirely sure the old version of the test should've passed for the failing test above, which is on python 3.3 but on the environment contains something like PYTHON=3.4... on py3.3 it should've been installed as f2py3.3, on 3.4 as f2py3.4, so something else seems dodgy in there...

i'm happy to squash if desired, but wanted to give the chance for reviewing the failing test above...

break
except FileNotFoundError:
pass
assert success, "wasn't able to find f2py or %s on commandline" % f2py_cmds[1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use assert_(...), plain old assert goes away when python runs optimized.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to import it from numpy.testing.

@charris charris added this to the 1.10.2 release milestone Dec 3, 2015
@joernhees
Copy link
Contributor Author

thanks, done & squashed.

charris added a commit that referenced this pull request Dec 5, 2015
TST: only test f2py, not f2py2.7 etc, fixes #6718
@charris charris merged commit a42cb55 into numpy:master Dec 5, 2015
@charris
Copy link
Member
charris commented Dec 5, 2015

Thanks @joernhees .

@charris charris removed this from the 1.10.2 release milestone Dec 5, 2015
@joernhees joernhees deleted the patch-1 branch December 6, 2015 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0