testing/utils: assert_almost_equal: use the same algorithm for rounding #6601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31446ae to
f461455
Compare
as used for assert_array_almost_equal Reference: numpy#5200 Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
f461455 to
0ad6bbd
Compare
| @@ -509,7 +509,7 @@ def _build_err_msg(): | |||
| return | |||
| except (NotImplementedError, TypeError): | |||
| pass | |||
| if round(abs(desired - actual), decimal) != 0: | |||
| if around(abs(desired - actual), decimal) >= 10.0**(-decimal): | |||
There was a problem hiding this comment.
I don't understand this logic. Either just round, or compare the absolute difference with some value.
|
I had missed the original discussion, but this seems wrong. Personally, I would simply write this as This should be identical to But one shouldn't combine them. p.s. Looking back, @charris also noted that he preferred the "first version" which just has the rounding. |
|
@ignatenkobrain Need to get this finished up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as used for assert_array_almost_equal
Reference: #5200