BUG: immutable _arraymethod function in ma.core #6588
Conversation
Replace the _arraymethod class in ma.core with a function factory which returns class method wrappers around basic array methods. These methods are bound to the MaskedArray instance and are immutable. Previously _arraymethod was a class which would incorrectly operate on the MaskedArray object which last accessed the particular named function. closes numpy#5247
|
Should be noted that wrapping methods in this manner results in a change in their call signatures. This does not seem to effect the generated documentation but may be an issue. >>> import numpy as np
>>> a = np.ma.arange(10)
>>> help(a.copy)New call signature: Old signature |
|
Looks good to me. The signature change isn't a problem - python doesn't have access to the signatures of ndarray methods anyway since they are implemented in C. This makes me think that the other decorators there ( I'd like let this sit for a day or so in case anyone else wants to look, and then merge. |
|
All right, merging. Thanks a lot @jjhemlus! |
BUG: immutable _arraymethod function in ma.core
|
Thanks for reviewing this @ahaldane. I'll have a look at the other decorates in the module and see if there is a compelling case to covert them to functions. |
Replace the _arraymethod class in ma.core with a function factory which
returns class method wrappers around basic array methods. These methods are
bound to the MaskedArray instance and are immutable.
Previously _arraymethod was a class which would incorrectly operate on the
MaskedArray object which last accessed the particular named function.
closes #5247