BUG: Fix for #6569, allowing build_ext --inplace #6577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is such a corner case that there's no specific TravisCI build needed for it. Otherwise we'll get an explosion of build configs. |
|
Fix looks fine to me, thanks @wackywendell. I'll leave it open for a day or so before merging. |
|
Thanks! |
rgommers
added a commit
that referenced
this pull request
Oct 29, 2015
BUG: Fix for #6569, allowing build_ext --inplace
|
Merged, thanks @wackywendell |
|
and will send backport PR |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6569, as discussed in the comments.
This does not test for reoccurence of this bug, or a similar one. To do so, I imagine we'd have to modify
travis.ymlortravis-test.shto callpython setup.py build_ext --inplace. Should I do that?CC @rgommers