8000 BLD: enable SSE2 for 32-bit msvc 9 and 10 compilers by cgohlke · Pull Request #6440 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BLD: enable SSE2 for 32-bit msvc 9 and 10 compilers #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

BLD: enable SSE2 for 32-bit msvc 9 and 10 compilers #6440

wants to merge 1 commit into from

Conversation

cgohlke
Copy link
Contributor
@cgohlke cgohlke commented Oct 9, 2015

Fixes #6428

@charris charris added this to the 1.10.1 release milestone Oct 10, 2015
@charris
Copy link
Member
charris commented Oct 10, 2015

Also marking this for 1.10.1 release consideration, but will wait to see if it is appropriate.

@cgohlke cgohlke mentioned this pull request Oct 10, 2015
Closed
charris
charris reviewed Oct 10, 2015
View reviewed changes
numpy/distutils/msvccompiler.py
@@ -15,3 +17,6 @@ def initialize(self, plat_name=None):
os.environ['lib'] = environ_lib + os.environ['lib']
if environ_include is not None:
os.environ['include'] = environ_include + os.environ['include']
if platform_bits == 32:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note on why SSE2 is reguired would be helpful. Is there anyway to make this specific to compiler versions <= 1500?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msvc will use the sse2 code anyway, this just makes it consistent over all of numpy

@charris charris mentioned this pull request Oct 10, 2015
Merged
@charris
Copy link
Member
charris commented Oct 10, 2015

Added comment in #6444, so closing this. Thanks Christoph.

@charris charris closed this Oct 10, 2015
charris added a commit that referenced this pull request Oct 11, 2015
@charris
Merge pull request #6444 from charris/gh-6440
20ef487 
Update 6440, BLD: enable SSE2 for 32-bit msvc 9 and 10 compilers.
@charris charris removed this from the 1.10.1 release milestone Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgohlke @charris @juliantaylor
0