8000 BUG: define "uint-alignment", fixes complex64 alignment by ahaldane · Pull Request #6377 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: define "uint-alignment", fixes complex64 alignment #6377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 30, 2018
Merged

BUG: define "uint-alignment", fixes complex64 alignment #6377

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
351e4b6
BUG: _strided_masked_wrapper_transfer_function goes out of bounds
ahaldane Sep 28, 2015
b76c0df
BUG: raw_array_is_aligned ignores NPY_RELAXED_STRIDES_CHECKING
ahaldane Jun 28, 2017
27d4ce9
ENH: Implement methods for uint-alignment
ahaldane Jun 28, 2017
1252b80
ENH: Make copy-code-paths check for uint-alignment
ahaldane Jun 29, 2017
8097aa3
ENH: Fix complex64 alignment
ahaldane Jun 29, 2017
33e1a7d
TST: Test complex64 alignment
ahaldane Sep 27, 2015
38af6dd
DOC: Document how memory alignment works as of 1.14
ahaldane Sep 27, 2015
12bd7c3
MAINT: remove unneeded test in npy_is_aligned
ahaldane Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MAINT: remove unneeded test in npy_is_aligned
  • Loading branch information
@ahaldane
ahaldane committed Sep 27, 2018
commit 12bd7c372ab5eeeff8bd2a46d765ccf28c6ce486
13 changes: 5 additions & 8 deletions numpy/core/src/multiarray/common.h
907C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,15 +197,12 @@ static NPY_INLINE int
npy_is_aligned(const void * p, const npy_uintp alignment)
{
/*
* alignment is usually a power of two
* the test is faster than a direct modulo
* Assumes alignment is a power of two, as required by the C standard.
* Assumes cast from pointer to uintp gives a sensible representation we
* can use bitwise & on (not required by C standard, but used by glibc).
* This test is faster than a direct modulo.
*/
if (NPY_LIKELY((alignment & (alignment - 1)) == 0)) {
return ((npy_uintp)(p) & ((alignment) - 1)) == 0;
}
else {
return ((npy_uintp)(p) % alignment) == 0;
}
return ((npy_uintp)(p) & ((alignment) - 1)) == 0;
}

/* Get equivalent "uint" alignment given an itemsize, for use in copy code */
Expand Down
0