10000 MRG: preparing for 1.9.4 release by matthew-brett · Pull Request #6350 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

MRG: preparing for 1.9.4 release #6350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 11, 2015

Conversation

matthew-brett
Copy link
Contributor

Add fixes for f2py installation from wheels, including tests.

juliantaylor and others added 5 commits September 23, 2015 17:13
allows pep 338 execution via python -mnumpy.f2py
Command `bdist_wheel` was generating a shebang line for f2py that uses
the Python path for the building Python.  If we are building a wheel or
an egg, use the generic `#!python` shebang line for the f2py script
instead, which setuptools will modify at install time.

Closes numpygh-5812.
Add other binary distribution formats to list of build commands that
should generate !python shebang lines.
bdist_mpkg is a very crude install method that will assume the path to
Python, so we should not use the `#!python` form when installing scripts
in bdist_mpkg.
Module tests whether we can run f2py and return correct version.

Skip this test when running in-place (we don't install f2py in that
case).

Use our own virtualenvs in travis-ci to avoid picking up travis' numpy.
@matthew-brett
Copy link
Contributor Author

@carlkl - any interest in getting the Windows build fixes in for this one?

@matthew-brett
Copy link
Contributor Author

@juliantaylor - do you want to add anything here?

@carlkl
Copy link
Member
carlkl commented Sep 24, 2015

@matthew-brett, I will make a PR my to maintainance/1.9.x today or tomorrow, and after that (if sucessfull tested) another PR to master.

@njsmith
Copy link
Member
njsmith commented Sep 24, 2015

Usually the rule is that all PRs go to master first, and then get
backported to maintenance branches (or not). Is there some reason this
needs to not follow that rule?
On Sep 24, 2015 9:43 AM, "carlkl" notifications@github.com wrote:

@matthew-brett https://github.com/matthew-brett, I will make a PR my to
maintainance/1.9.x today or tomorrow, and after that (if sucessfull tested)
another PR to master.


Reply to this email directly or view it on GitHub
#6350 (comment).

@carlkl
Copy link
Member
carlkl commented Sep 24, 2015

numpy master contains some mingw-w64 patches, maintainance-1.9,x none of them. I could be difficult to merge. I could send a complete numpy-1.9.3 patch as an alternative after a master PR.

@charris
Copy link
Member
charris commented Sep 24, 2015

@carlkl Don't worry about it. It would be good if you could get the PR to master done before the 1.10.0 release.

@carlkl
Copy link
Member
carlkl commented Sep 24, 2015

Hi folks,

mingwpy PR is now in #6354. Uses https://anaconda.org/carlkl/mingwpy (mingw-w64 wheel installable) and https://bitbucket.org/carlkl/mingw-w64-for-python/downloads/OpenBLAS_mingwpy_amd64.7z / https://bitbucket.org/carlkl/mingw-w64-for-python/downloads/OpenBLAS_mingwpy-win32.7z.
I encountered some new errors in numpy.test() with numpy.master I have to dig in.

@charris
Copy link
Member
charris commented Dec 10, 2015

@matthew Still want to pursue this?

@matthew-brett
Copy link
Contributor Author

What do you think? Are people still installing 1.9.x do you think?

By the way github user "matthew" is sadly not me but someone quicker to github awesomeness than me.

@charris
Copy link
Member
charris commented Dec 10, 2015

People are definitely still using 1.9 as it is in many distros. OTOH, 1.10.2 should be out in time for the spring distro releases and I think it should be a decent release. I was asking because there wasn't much activity here and I'm trying to cleanup the PR pile. No problem if you want to keep working on this, just say so.

@matthew-brett matthew-brett changed the title WIP: preparing for 1.9.4 release MRG: preparing for 1.9.4 release Dec 10, 2015
@matthew-brett
Copy link
Contributor Author

What about merging this one to maintenance for now, and seeing how it goes after 1.10.2 ?

@charris
Copy link
Member
charris commented Dec 11, 2015

Fine with me, your choice.

matthew-brett added a commit that referenced this pull request Dec 11, 2015
MRG: preparing for potential 1.9.4 release

Fix f2py shebang line error for wheel installs.
@matthew-brett matthew-brett merged commit c2b6ab9 into numpy:maintenance/1.9.x Dec 11, 2015
@matthew-brett
Copy link
Contributor Author

Thanks - I endorse my own work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0