8000 Backport gh-6243 by charris · Pull Request #6340 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Backport gh-6243 #6340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 22, 2015
Merged

Backport gh-6243 #6340

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bf83c4
Added closing for 'so_dup' and 'se_dup' file descriptors.
dmitrii-zagornyi Sep 14, 2015
7cba81b
MSVCCompiler overwrite 'lib' and 'include' environment variables. This
dmitrii-zagornyi Sep 14, 2015
c628401
Fixed issue: SciPy can't be build in case, if python was installed into
dmitrii-zagornyi Sep 14, 2015
ed6e960
Align with pep8
dmitrii-zagornyi Sep 14, 2015
4cc0dda
Changed from distutils_MSVCCompiler to
dmitrii-zagornyi Sep 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files. 8000
Loading
Diff view
Diff view
Next Next commit
Added closing for 'so_dup' and 'se_dup' file descriptors. 
Issue: _exec_command function doesn't close 'so_dup' and 'se_dup' file
descriptors.SciPy try to build scipy\special\amos\zunik.f and
crash:error: Command "C:\Program Files (x86)\Intel\Composer XE
2015\bin\intel64\ifort.exe /nologo /MD /nbs /names:lowercase
/assume:underscore /O1
-IC:\Python27\lib\site-packages\numpy\core\include -c /c
scipy\special\amos\zunik.f
/Fobuild\temp.win-amd64-2.7\scipy\special\amos\zunik.o" failed with
exit status -1073741502
  • Loading branch information
@dmitrii-zagornyi @charris
dmitrii-zagornyi authored and charris committed Sep 22, 2015
commit 8bf83c45c13051b4f91cc252084a17b6c176cfa6
2 changes: 2 additions & 0 deletions numpy/distutils/exec_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,8 +441,10 @@ def _exec_command( command, use_shell=None, use_tee = None, **env ):
se_flush()
if _so_has_fileno:
os.dup2(so_dup, so_fileno)
os.close(so_dup)
if _se_has_fileno:
os.dup2(se_dup, se_fileno)
os.close(se_dup)

fout.close()
fout = open_latin1(outfile, 'r')
Expand Down
0