ENH: add user control to check embedded lapack in openblas #5855
Conversation
Linking openblas without lapack support can in certain cases fail due to erronous test. Instead of trying to fix tests for linking correctly a library we allow the user to control the build in check. This can be acheived by adding: [openblas] embedded_lapack = True which then forces lapack to embedded. I have added comments in site.cfg.example to explain when and how it can be used.
|
@juliantaylor Comments? |
|
The comments in |
|
@zerothi could you give a concrete example for how to make this check fail but the build of a package that relies on this passing? That would help with testing this PR. Improving the test would also still be useful, even when we do allow manual control via |
|
Basically there are two situations:
will fail as it only checks for lapack existence in the openblas library, not in the combined linking path and libraries in the openblas block.
will succeed and build will assume that lapack can be found on the linking path and supplied libraries. I was a bit unsure of the wording embedded_lapack, but this was a small abstraction. |
|
@charris @juliantaylor this doesn't look too hard to merge and is probably correct, but I won't get around to it before end October. Can one of you look at it? |
Linking openblas without lapack support can in certain cases
fail due to erronous test. Instead of trying to fix tests
for linking correctly a library we allow the user to control
the build in check.
This can be acheived by adding:
[openblas]
embedded_lapack = True
which then forces lapack to be embedded.
I have added comments in site.cfg.example to explain when and
how it can be used.